Skip to content

docs: update mesh demo #4999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
psybuzz merged 3 commits into from
May 25, 2021
Merged

docs: update mesh demo #4999

psybuzz merged 3 commits into from
May 25, 2021

Conversation

@psybuzz
Copy link
Contributor

@psybuzz psybuzz commented May 20, 2021 •
edited
Loading

Merges mesh_demo.py and mesh_demo_v2.py into a single demo,
dropping the TF1 version.

Manually tested by running bazel run //tensorboard/plugins/mesh:mesh_demo
and opening the Mesh dashboard and seeing that it looks unchanged.
image

@google-cla google-cla bot added the cla: yes label May 20, 2021
@psybuzz psybuzz requested a review from nfelt May 20, 2021 21:57
nfelt
nfelt approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@nfelt nfelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! CI failed due to needing a BUILD file change too I believe.

I guess this means #2578 is officially stale, huh :P

tensorboard/plugins/mesh/mesh_demo.py Outdated
if int(tf.__version__.split(".")[0]) > 1:
raise ImportError("TensorFlow 1.x is required to run this demo.")
"""Runs training steps with a mesh summary."""
# Flag mesh_path is required.
Copy link
Contributor

@nfelt nfelt May 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional since this isn't really TF 2.0 related, but it would be nice if this was self-contained. As reported by @wchargin (oh hai) on #2578 there is a .ply file in-repo that we could bundle to make this simpler to run:

https://github.com/tensorflow/tensorboard/blob/master/tensorboard/plugins/mesh/test_data/icosphere.ply

Copy link
Contributor Author

@psybuzz psybuzz May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@psybuzz psybuzz merged commit 0e2b827 into tensorflow:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nfelt nfelt nfelt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes type:docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@psybuzz @nfelt